PR 1218, round four: the author's fixes

harvester/harvester-ui-extension#1218 by wheatdog, head a3392e7 on main f3ca9e4. Reviewed 2026-11-16 with Cody's round-two process (my-pr-review-new-commits at c04c11a) and ours, then merged. Nothing is posted.

Where it was tested: the SUSE VPN is down, so the standalone previews load but can't reach a Harvester. Every live check ran on the PR's extension build loaded into mf's Rancher v2.16 in a test browser (the installed harvester extension blocked there only), on harvester-11-2 (.105; its API now reports master-9dd27fdb-head, a side-loaded master build on v1.10.0-rc1) and harvester-118 (.118, v1.9.0-rc4). Every save was held in the browser and every session logged out. Both previews are rebuilt at a3392e7 and f3ca9e4 for when the VPN is back.

Approvegrade A-

Both comments from your 11-10 review are fixed, proven with the same checks that found them, and the new commit adds no problem of its own. CI is green, the conflict is gone, and the PR is blocked only on an approval. Approving now is safe: no push is pending.

Your two comments, now
1

Radio groups have no name for screen readers

Addressed
Screen readers get no name for this group: the bold label above it isn't tied to it, so it's announced as just "Enabled / Disabled". Restore VM right above has the same gap, so the two can't be told apart. Passing each label's text to its `RadioGroup` as `aria-label` would name both without changing how they look. [image: accessible names of the two radio groups]
addressed in https://github.com/harvester/harvester-ui-extension/pull/1218/changes/a88dde33d7cbd3df4a0122f0ce0c985a07c01518

What changed

Both RadioGroups get :aria-label with their own label's translation key (lines 189 and 200). The reply links a88dde3, the rebased feature commit; the change is in a3392e7. Harmless.

Checked the same way as on 11-10

Chromium's accessibility tree of the live form in Rancher: main has one unnamed radiogroup (Restore VM); the PR build has radiogroup "Restore VM" and radiogroup "Shut Down VM on Migration Failure". A real Tab walk lands on each by name, Arrow Up picks Enabled, and on the v1.9 cluster Restore VM is named too. The name is the visible label's own text. axe 4.10.2: 0 violations. Both passes got the same result.
round 3
On 11-10 (d73d8aa): both groups unnamed. Round three's capture.
now
Now (a3392e7), in Rancher on harvester-11-2: both named.
2

The save test never went through the radio group

Addressed
Nit, optional: this test sets `parseDefaultValue` and calls `update()` itself, so it never goes through the radio group. Removing `@update:value` from the new group, or binding it to `restoreVM` by mistake, still passes all five tests. Emitting `update:value` from the group's stub would catch both. [image: deliberate breakages run against this spec]
addressed in https://github.com/harvester/harvester-ui-extension/pull/1218/changes/a88dde33d7cbd3df4a0122f0ce0c985a07c01518

What changed

"should save the value selected in its radio group" now emits update:value from each group's stub and checks both fields; a new test checks both names. Spec 6/6 and feature-flags 7/7 pass; CI lint and unit tests are green.

Checked the same way as on 11-10

Breaking the component one way at a time and running the spec, at the old head and at the new one (Pass B's table). Both breakages from your comment pass the old spec and fail the new one; dropping or swapping either label and dropping Restore VM's handler now fail too. Pass A ran the same breakages on the new spec and got the same result.
mutation table
Pass B: each breakage against the spec at d73d8aa and at a3392e7.
See it

The change is invisible on screen, so the clip Tabs through the form for real and puts in the caption what the accessibility tree gives a screen reader for the focused group.

PR build in Rancher (40 s): harvester-11-2 > Settings > upgrade-config > Edit; Tab to radiogroup "Restore VM", Tab to radiogroup "Shut Down VM on Migration Failure", Arrow Up to Enabled, Save (sent to that cluster with true, held); then harvester-118 (v1.9): the control is hidden and Restore VM is named.
main
main (f3ca9e4) on the same cluster: Restore VM's group has no name.
v1.9 cluster
PR build on harvester-118 (v1.9.0-rc4): no new control.
What the new commits change, and what else I checked
The two passes side by side
Cody's processOurs
VerdictReady to approve (his flow leaves the verdict to you).Approve, A-.
Earlier comments2 of 2 Addressed.2 of 2 Addressed.
How they were provenAX tree of main and the PR in Rancher, a real Tab walk clip, axe; 7 breakages run against the new spec.AX tree, a keyboard and Save clip, axe; 10 breakages run against the old and the new spec side by side.
Only this passAnnotated before/after stills; checked the docs link now explains the field; the label 12036 gained.Spotted that your review-body question is unanswered on GitHub; spotted that .105 now reports a master version; a UX point on unchanged code (S1).
Missed or wrongMissed the review-body question. Its clip's title card said .105 runs v1.10.0-rc1; corrected and re-recorded before publishing. One breakage in its script hit the wrong handler first; fixed and re-run.Nothing wrong found. S1 is real but on code you reviewed twice; see below.
CostIn this session, with the earlier rounds in context.About 18 minutes, 74 tool calls, about 223k tokens, as a fresh agent.
UX comparison
Pass B's evidence for the UX point it raised outside the new commits (see "Seen, not for the review").
Pass B's clip (26 s): keyboard to the named group, Enabled, Save on the v1.10 cluster, then the v1.9 cluster.
Seen, not for the review
What I'd post

Approve, with one short body that also answers your own question. No thread replies needed: the body says both points are fixed, and you can resolve the two threads yourself.

Thanks, both points are fixed. On my question: I tried it as an extension in Rancher v2.16, on a v1.10 cluster where the control shows and saves, and on a v1.9 one, where it stays hidden.

No preview link, no code. If you'd rather keep the UX point, it would go in as a Comment instead of an approval, and it would be a fourth round for the author on code you've already passed twice.

What was and wasn't checked